New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] metainfo of dataset can be a generic dict-like Mapping #1378
Conversation
Hi @hiyyg , thanks for your contribution. What additional mapping types do you want to support? Can you add the corresponding unit tests? |
For example, when the metainfo is provided by a config dict created by omegaconf or other config systems, they are Mapping but not dict. |
Where should the tests be added? Could you give me some guidances? |
got it |
Hi, you can add the unit tests in the following method.
|
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Allowing metainfo to be more generic, so that it is compatible with other dict-like config systems.
Modification
Please briefly describe what modification is made in this PR.
Allowing metainfo to be
Mapping
(more generic), instead of justdict
.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist