Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] metainfo of dataset can be a generic dict-like Mapping #1378

Merged
merged 3 commits into from Oct 8, 2023

Conversation

hiyyg
Copy link
Contributor

@hiyyg hiyyg commented Oct 5, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Allowing metainfo to be more generic, so that it is compatible with other dict-like config systems.

Modification

Please briefly describe what modification is made in this PR.

Allowing metainfo to be Mapping (more generic), instead of just dict.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?

No

If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hiyyg hiyyg requested a review from HAOCHENYE as a code owner October 5, 2023 16:15
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@zhouzaida
Copy link
Member

Hi @hiyyg , thanks for your contribution. What additional mapping types do you want to support? Can you add the corresponding unit tests?

@hiyyg
Copy link
Contributor Author

hiyyg commented Oct 6, 2023

Hi @hiyyg , thanks for your contribution. What additional mapping types do you want to support? Can you add the corresponding unit tests?

For example, when the metainfo is provided by a config dict created by omegaconf or other config systems, they are Mapping but not dict.

@hiyyg
Copy link
Contributor Author

hiyyg commented Oct 6, 2023

Where should the tests be added? Could you give me some guidances?

@zhouzaida
Copy link
Member

Hi @hiyyg , thanks for your contribution. What additional mapping types do you want to support? Can you add the corresponding unit tests?

For example, when the metainfo is provided by a config dict created by omegaconf or other config systems, they are Mapping but not dict.

got it

@zhouzaida
Copy link
Member

zhouzaida commented Oct 7, 2023

Where should the tests be added? Could you give me some guidances?

Hi, you can add the unit tests in the following method.

@zhouzaida zhouzaida changed the title metainfo can be a generic dict-like Mapping instead of just dict [Enhance] metainfo of dataset can be a generic dict-like Mapping Oct 8, 2023
@zhouzaida zhouzaida merged commit eb5834f into open-mmlab:main Oct 8, 2023
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants