Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Support multi-node distributed training with NPU backend #1459

Merged
merged 1 commit into from Dec 26, 2023

Conversation

shun001
Copy link
Contributor

@shun001 shun001 commented Dec 26, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

Fix the problem that multi-node distributed training would fail at initial when training with NPU.

Modification

In mmengine/dist/util.py, we change rank to local rank when initializing process group with NPU.

BC-breaking (Optional)

None

Use cases (Optional)

None

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida zhouzaida merged commit 8e6fb12 into open-mmlab:main Dec 26, 2023
10 of 13 checks passed
@shun001 shun001 deleted the main-lzs1 branch December 27, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants