Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Right align the log #436

Merged
merged 7 commits into from Nov 21, 2022
Merged

[Enhance] Right align the log #436

merged 7 commits into from Nov 21, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Aug 15, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The original log:
image

The aligned log:
image

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne added this to the 0.6.0 milestone Aug 25, 2022
@ZwwWayne ZwwWayne added the P1 label Sep 2, 2022
@HAOCHENYE HAOCHENYE modified the milestones: 0.2.0, 0.4.0 Oct 27, 2022
@HAOCHENYE HAOCHENYE added the enhancement New feature or request label Oct 27, 2022
# Conflicts:
#	mmengine/runner/log_processor.py
@ZwwWayne ZwwWayne merged commit b06234c into main Nov 21, 2022
@zhouzaida zhouzaida deleted the HAOCHENYE/allign_the_log branch November 21, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants