Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] wandb image #510

Merged
merged 3 commits into from Sep 7, 2022
Merged

Conversation

okotaku
Copy link
Contributor

@okotaku okotaku commented Sep 3, 2022

Motivation

'wandb add_image' does not upload images but array.

スクリーンショット 2022-09-03 18 42 38

Modification

By using wandb.Image, it can upload images.

スクリーンショット 2022-09-03 18 59 28

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne added this to the 0.2.0 milestone Sep 5, 2022
ZwwWayne
ZwwWayne previously approved these changes Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@ba1c368). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage        ?   77.54%           
=======================================
  Files           ?      116           
  Lines           ?     8604           
  Branches        ?     1775           
=======================================
  Hits            ?     6672           
  Misses          ?     1637           
  Partials        ?      295           
Flag Coverage Δ
unittests 77.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Sep 5, 2022

Hi @okotaku ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@okotaku
Copy link
Contributor Author

okotaku commented Sep 5, 2022

Hi @okotaku , Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR? The details can be found by clicking the item of lint check as shown below image

The lint issue is docstring coverage. It's not the problem of this PR. I think it should be fixed another PR or I can set less 'minimum' to 85 or less.

@ZwwWayne ZwwWayne merged commit 34bd3e5 into open-mmlab:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants