Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Support compare numpy array dataset meta #511

Merged
merged 2 commits into from Sep 22, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Sep 5, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix #438

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@ba1c368). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 3c8edd5 differs from pull request most recent head 462d911. Consider uploading reports for the commit 462d911 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage        ?   77.54%           
=======================================
  Files           ?      116           
  Lines           ?     8604           
  Branches        ?     1775           
=======================================
  Hits            ?     6672           
  Misses          ?     1637           
  Partials        ?      295           
Flag Coverage Δ
unittests 77.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne requested a review from C1rN09 September 6, 2022 02:41
@ZwwWayne ZwwWayne added this to the 0.2.0 milestone Sep 6, 2022
@ZwwWayne ZwwWayne merged commit 8d14eb6 into open-mmlab:main Sep 22, 2022
xcnick pushed a commit to xcnick/mmengine that referenced this pull request Sep 26, 2022
* [Fix] Support compare numpy array dataset meta

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when use --resume because of the dataset meta comparsion
2 participants