Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Call register_all_modules in Registry.get() #541

Merged
merged 7 commits into from Oct 24, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

If we use config like this:

model = dict(type='RetinaNet'
    backbone=dict(type='mmcls.ResNet'
    ...
    )
)

MODELS.build(model) will NOT regist modules of mmcl, and we need to set custom_configs=... in config file extraly.

However, if we set _scope_ in config:

model = dict(type='RetinaNet'
    _scope_='mmcls',
    backbone=dict(type='ResNet'
    ...
    )
)

The modules of mmcls will be registered, and its behavior is inconsistent with type=mmcls.ResNet.
Therefore, this pr make type=mmcls.ResNet will also trigger the regist process.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@HAOCHENYE HAOCHENYE changed the base branch from main to dev September 23, 2022 03:06
@ZwwWayne ZwwWayne changed the base branch from dev to main October 8, 2022 03:27
Harold-lkk
Harold-lkk previously approved these changes Oct 21, 2022
mmengine/registry/registry.py Outdated Show resolved Hide resolved
mmengine/registry/registry.py Outdated Show resolved Hide resolved
fangyixiao18
fangyixiao18 previously approved these changes Oct 24, 2022
@zhouzaida zhouzaida added this to the 0.3.0 milestone Oct 24, 2022
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida changed the title [Ehance] Call register_all_modules in Registry.get() [Enhance] Call register_all_modules in Registry.get() Oct 24, 2022
zhouzaida
zhouzaida previously approved these changes Oct 24, 2022
Harold-lkk
Harold-lkk previously approved these changes Oct 24, 2022
RangiLyu
RangiLyu previously approved these changes Oct 24, 2022
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typos

@HAOCHENYE HAOCHENYE dismissed stale reviews from Harold-lkk and zhouzaida via ffa4a8f October 24, 2022 11:54
@zhouzaida zhouzaida merged commit c144773 into open-mmlab:main Oct 24, 2022
C1rN09 pushed a commit to C1rN09/mmengine that referenced this pull request Nov 1, 2022
…#541)

* call register_all_modules  in Registry.get()

* Fix ci

* fix scope bug (scope_name -> scope), for temp sync

* Fix unit test

* Refine log information

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Fix typo

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants