Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] typo #569

Merged
merged 1 commit into from Oct 8, 2022
Merged

[Fix] typo #569

merged 1 commit into from Oct 8, 2022

Conversation

yhna940
Copy link
Contributor

@yhna940 yhna940 commented Oct 4, 2022

Motivation

There is a typo in the FSDP wrapping policy.

@yhna940 yhna940 changed the title Fix typo [Fix] typo Oct 4, 2022
@ZwwWayne ZwwWayne added this to the 0.2.0 milestone Oct 8, 2022
C1rN09
C1rN09 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

HAOCHENYE
HAOCHENYE approved these changes Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HAOCHENYE
Copy link
Collaborator

Hi! We update our CI, please update the code and make sure that it could pass the lint.

@ZwwWayne ZwwWayne merged commit da38b41 into open-mmlab:main Oct 8, 2022
C1rN09 pushed a commit to C1rN09/mmengine that referenced this pull request Nov 1, 2022
@yhna940 @C1rN09
Fix typo in FSDP (open-mmlab#569)
1471aee
@OpenMMLab-Assistant001
Copy link

Hi @yhna940 ~

First of all, we want to express our gratitude for your significant PR in the MMEngine project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution！❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HAOCHENYE HAOCHENYE HAOCHENYE approved these changes

@C1rN09 C1rN09 C1rN09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yhna940 @HAOCHENYE @OpenMMLab-Assistant001 @C1rN09 @ZwwWayne