Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] some out-of-date unittests #586

Merged
merged 2 commits into from Oct 8, 2022
Merged

[Fix] some out-of-date unittests #586

merged 2 commits into from Oct 8, 2022

Conversation

C1rN09
Copy link
Collaborator

@C1rN09 C1rN09 commented Oct 8, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix some unittests

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ZwwWayne ZwwWayne merged commit e73c4bf into open-mmlab:main Oct 8, 2022
C1rN09 added a commit to C1rN09/mmengine that referenced this pull request Nov 1, 2022
* fix dist ut

* fix config & hub ut break due to mmdet faster-rcnn rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants