Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Translate installation and 15_min #629

Merged
merged 17 commits into from Oct 19, 2022
Merged

[Docs] Translate installation and 15_min #629

merged 17 commits into from Oct 19, 2022

Conversation

xin-li-67
Copy link
Contributor

Motivation

Translate documents

Modification

docs/en/get_started/15_minutes.md
docs/en/get_started/installation.md

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida
Copy link
Member

Hi @xin-li-67 , thanks for your contribution.

@zhouzaida zhouzaida requested a review from C1rN09 October 18, 2022 08:24
@zhouzaida zhouzaida added this to the 0.3.0 milestone Oct 18, 2022
@zhouzaida zhouzaida changed the title translate installation and 15_min [Docs] Translate installation and 15_min Oct 18, 2022
xin-li-67 and others added 10 commits October 18, 2022 17:00
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
0e81c9d 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
6251a5c 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
3870aff 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
6e8fff2 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
e9a1227 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
7f1334b 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
8ed665a 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/15_minutes.md
a2c1b18 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/15_minutes.md
ae3c681 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/15_minutes.md
57871d3 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
xin-li-67 and others added 2 commits October 18, 2022 17:21
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
f0ae352 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@xin-li-67 @zhouzaida
Update docs/en/get_started/installation.md
e2ca588 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
zhouzaida
zhouzaida previously approved these changes Oct 18, 2022
View reviewed changes
@C1rN09
Copy link
Collaborator

C1rN09 commented Oct 18, 2022

Hi, thanks for your contribution! As a reminder, we are currently working on a refine of some Chinese documentations. The range covers tutorials, advance tutorials and architecture design. Since the above mentioned docs are due to change, you might translate other docs if you are willing to continue your contribution ^_^

@C1rN09
Copy link
Collaborator

C1rN09 commented Oct 18, 2022

Another thing, we recommend merging into main branch directly in MMEngine. Could you change the destination?

@zhouzaida zhouzaida changed the base branch from dev to main October 18, 2022 14:03
@zhouzaida zhouzaida dismissed their stale review October 18, 2022 14:03

The base branch was changed.

xin-li-67 and others added 4 commits October 19, 2022 08:36
@xin-li-67 @C1rN09
Update docs/en/get_started/15_minutes.md
9425b23 
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
@xin-li-67 @C1rN09
Update docs/en/get_started/15_minutes.md
c15862e 
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
@xin-li-67 @C1rN09
Update docs/en/get_started/15_minutes.md
f51c768 
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
@xin-li-67 @C1rN09
Update docs/en/get_started/installation.md
d4ee58d 
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
C1rN09
C1rN09 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida merged commit dc01545 into open-mmlab:main Oct 19, 2022
@xin-li-67 xin-li-67 deleted the get_started_translate branch October 19, 2022 04:48
C1rN09 added a commit to C1rN09/mmengine that referenced this pull request Nov 1, 2022
@xin-li-67 @zhouzaida @C1rN09
[Docs] Translate installation and 15_min (open-mmlab#629)
ff47d11 
* translate installation and 15_min

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/15_minutes.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/15_minutes.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/15_minutes.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* Update docs/en/get_started/15_minutes.md

Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>

* Update docs/en/get_started/15_minutes.md

Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>

* Update docs/en/get_started/15_minutes.md

Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>

* Update docs/en/get_started/installation.md

Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C1rN09 C1rN09 C1rN09 approved these changes

@zhouzaida zhouzaida zhouzaida left review comments

Assignees

@zhouzaida zhouzaida

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xin-li-67 @zhouzaida @C1rN09