Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix CosineRestart eta_min #639

Merged
merged 4 commits into from Nov 1, 2022

Conversation

Z-Fran
Copy link
Contributor

@Z-Fran Z-Fran commented Oct 24, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Z-Fran Z-Fran requested a review from RangiLyu as a code owner October 24, 2022 10:20
@HAOCHENYE HAOCHENYE added this to the 0.3.0 milestone Oct 27, 2022
HAOCHENYE
HAOCHENYE previously approved these changes Oct 27, 2022
@RangiLyu
Copy link
Member

add some unit tests to cover this case

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@dc01545). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 9edad80 differs from pull request most recent head 152c029. Consider uploading reports for the commit 152c029 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage        ?   78.49%           
=======================================
  Files           ?      126           
  Lines           ?     9132           
  Branches        ?     1816           
=======================================
  Hits            ?     7168           
  Misses          ?     1652           
  Partials        ?      312           
Flag Coverage Δ
unittests 78.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure the added unit test will throw an error if the code has not been modified.

@zhouzaida zhouzaida merged commit 090104d into open-mmlab:main Nov 1, 2022
ly015 pushed a commit to ly015/mmengine that referenced this pull request Nov 9, 2022
…ab#639)

* [Fix] fix CosineRestart eta_min

* add ut case

* Enhance unit test

Enhance unit test

* remove unused code

Co-authored-by: HAOCHENYE <21724054@zju.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants