New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] fix CosineRestart eta_min #639
Conversation
add some unit tests to cover this case |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
=======================================
Coverage ? 78.49%
=======================================
Files ? 126
Lines ? 9132
Branches ? 1816
=======================================
Hits ? 7168
Misses ? 1652
Partials ? 312
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure the added unit test will throw an error if the code has not been modified.
Enhance unit test
…ab#639) * [Fix] fix CosineRestart eta_min * add ut case * Enhance unit test Enhance unit test * remove unused code Co-authored-by: HAOCHENYE <21724054@zju.edu.cn>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist