Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change strict_load of EMAHook to False by default #642

Merged
merged 2 commits into from Oct 28, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Resolve #607.

Since #542 makes load_state_dict not save or load non-persistent buffer anymore, resuming the old checkpoint with std and mean will cause the error described in #607.

The default resume strategy of EMAHook should be consistent with Runner. Since Runner does not load checkpoint strictly, the default value of load_strict in EMAHook should be False.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@HAOCHENYE HAOCHENYE added this to the 0.3.0 milestone Oct 27, 2022
RangiLyu
RangiLyu previously approved these changes Oct 27, 2022
C1rN09
C1rN09 previously approved these changes Oct 28, 2022
@zhouzaida zhouzaida dismissed stale reviews from C1rN09 and RangiLyu via 0f76bda October 28, 2022 09:12
@zhouzaida zhouzaida changed the title [Fix] Fix resume std and mean in EMAHook Change strict_load of EMAHook to False by default Oct 28, 2022
@zhouzaida zhouzaida merged commit d1d32df into open-mmlab:main Oct 28, 2022
ly015 pushed a commit to ly015/mmengine that referenced this pull request Nov 9, 2022
* [Fix] resume std and mean

* refine docstring

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]resume error
4 participants