[Enhance] support eta_min_ratio in CosineAnnealingParamScheduler #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cir7
force-pushed
the
lilin/support_eta_min_ratio
branch
2 times, most recently
from
0da0742
to
c5a290c
Compare
cir7
force-pushed
the
lilin/support_eta_min_ratio
branch
from
c5a290c
to
43f52fb
Compare
RangiLyu
reviewed
Nov 16, 2022
RangiLyu
reviewed
Nov 16, 2022
Codecov ReportBase: 78.41% // Head: 78.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
- Coverage 78.41% 78.40% -0.01%
==========================================
Files 127 127
Lines 9178 9184 +6
Branches 1826 1827 +1
==========================================
+ Hits 7197 7201 +4
- Misses 1670 1671 +1
- Partials 311 312 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cir7
force-pushed
the
lilin/support_eta_min_ratio
branch
from
de9969f
to
2019b1a
Compare
RangiLyu
previously approved these changes
Nov 17, 2022
HAOCHENYE
reviewed
Nov 17, 2022
HAOCHENYE
reviewed
Nov 17, 2022
zhouzaida
reviewed
Nov 20, 2022
zhouzaida
reviewed
Nov 20, 2022
zhouzaida
reviewed
Nov 20, 2022
HAOCHENYE
reviewed
Nov 21, 2022
zhouzaida
previously approved these changes
Nov 22, 2022
RangiLyu
reviewed
Nov 22, 2022
zhouzaida
reviewed
Nov 22, 2022
zhouzaida
reviewed
Nov 22, 2022
zhouzaida
reviewed
Nov 22, 2022
zhouzaida
approved these changes
Nov 22, 2022
RangiLyu
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
[Enhance] support eta_min_ratio in CosineAnnealingParamScheduler
[doc] fix a typo in CosineRestartParamScheduler's docstring