Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bug of CosineAnnealingParamScheduler #735

Merged
merged 1 commit into from Nov 19, 2022

Conversation

fangyixiao18
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

As T_max could be None, so we need to check its value.

Modification

Add value check of T-max in CosineAnnealingParamScheduler

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 78.41% // Head: 78.40% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0da0bda) compared to base (e98d262).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   78.41%   78.40%   -0.01%     
==========================================
  Files         127      127              
  Lines        9178     9179       +1     
  Branches     1826     1827       +1     
==========================================
  Hits         7197     7197              
  Misses       1670     1670              
- Partials      311      312       +1     
Flag Coverage Δ
unittests 78.40% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmengine/optim/scheduler/param_scheduler.py 87.90% <50.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HAOCHENYE HAOCHENYE added the bug Something isn't working label Nov 17, 2022
@HAOCHENYE HAOCHENYE added this to the 0.4.0 milestone Nov 17, 2022
@zhouzaida zhouzaida merged commit 9d5b417 into open-mmlab:main Nov 19, 2022
@fangyixiao18 fangyixiao18 deleted the fix-cosannealing-bug branch December 15, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants