Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Translate data transform docs. #737

Merged
merged 3 commits into from Dec 7, 2022
Merged

[Docs] Translate data transform docs. #737

merged 3 commits into from Dec 7, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Nov 17, 2022

Motivation

Add data transform doc translation.

Modification

Add data transform doc translation. And modify the intersphinx link to mmcv.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@HAOCHENYE HAOCHENYE added the documentation Improvements or additions to documentation label Nov 17, 2022
@HAOCHENYE HAOCHENYE added this to the 0.4.0 milestone Nov 17, 2022
@mzr1996 mzr1996 changed the base branch from main to docs_refactor November 18, 2022 03:39
@mzr1996 mzr1996 requested a review from C1rN09 November 18, 2022 04:30
C1rN09
C1rN09 reviewed Nov 29, 2022
View reviewed changes
docs/en/migration/transform.md Show resolved Hide resolved
docs/en/migration/transform.md Outdated Show resolved Hide resolved
docs/en/migration/transform.md Outdated Show resolved Hide resolved
docs/en/migration/transform.md Outdated Show resolved Hide resolved
docs/en/migration/transform.md Outdated Show resolved Hide resolved
docs/en/migration/transform.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_transform.md Show resolved Hide resolved
docs/zh_cn/advanced_tutorials/data_transform.md Show resolved Hide resolved
@mzr1996 mzr1996 requested a review from C1rN09 December 5, 2022 06:10
C1rN09
C1rN09 previously approved these changes Dec 5, 2022
View reviewed changes
@zhouzaida zhouzaida force-pushed the docs_refactor branch 2 times, most recently from 383912b to 3a5f571 Compare December 6, 2022 06:23
@zhouzaida zhouzaida changed the base branch from docs_refactor to main December 6, 2022 09:23
@zhouzaida zhouzaida dismissed C1rN09’s stale review December 6, 2022 09:23

The base branch was changed.

zhouzaida
zhouzaida reviewed Dec 6, 2022
View reviewed changes
docs/en/tutorials/data_transform.md Outdated
figure, after which, every blue block represents a data transform, and in every data transform, we add some new fields (marked in green) or update some existing fields (marked in orange) in the data dictionary.

<div align=center>
<img src="https://user-images.githubusercontent.com/26739999/187157681-ac4dcac8-3543-4bfe-ab30-9aa9e56d4900.jpg" width="90%"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the water mark.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to remove it

@zhouzaida
Copy link
Member

This PR can be merged after resolving comments and conflicts.

@zhouzaida zhouzaida merged commit 6a3028c into open-mmlab:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@C1rN09 C1rN09 C1rN09 left review comments

@HAOCHENYE HAOCHENYE Awaiting requested review from HAOCHENYE

@RangiLyu RangiLyu Awaiting requested review from RangiLyu

Assignees

@ice-tong ice-tong

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mzr1996 @zhouzaida @C1rN09 @ice-tong @HAOCHENYE