Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add progress arg #770

Merged
merged 1 commit into from Dec 26, 2022
Merged

add progress arg #770

merged 1 commit into from Dec 26, 2022

Conversation

austinmw
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fixes #755

Modification

Checks if tty-like environment when using torch progress bars

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!!
image

@HAOCHENYE HAOCHENYE added the enhancement New feature or request label Nov 30, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@HAOCHENYE HAOCHENYE added the ready ready to merge label Dec 16, 2022
@HAOCHENYE HAOCHENYE added this to the 0.4.0 milestone Dec 16, 2022
@zhouzaida zhouzaida merged commit eb803f8 into open-mmlab:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Disable download progress bars
4 participants