Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor checkpointhook unittest #789

Merged

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Dec 5, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

If the metric name contains / character, such as 'top10/acc', CheckpointHook will first create the best_top10 directory and save the best checkpoint in it, which is not our expected:

best_top10
└── acc_epoch_5.pth

This PR will replace all / with _ to prevent from creating an unnecessary directory.

best_top10_acc_epoch_5.pth

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@fd84c21). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 75bc93c differs from pull request most recent head cdc86ef. Consider uploading reports for the commit cdc86ef to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage        ?   76.69%           
=======================================
  Files           ?      139           
  Lines           ?    11035           
  Branches        ?     2207           
=======================================
  Hits            ?     8463           
  Misses          ?     2209           
  Partials        ?      363           
Flag Coverage Δ
unittests 76.69% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HAOCHENYE HAOCHENYE added this to the 0.6.0 milestone Jan 12, 2023
@HAOCHENYE HAOCHENYE force-pushed the refactor_hooks_unittest branch 3 times, most recently from 30f11d5 to 32e2ef0 Compare February 21, 2023 14:47
@zhouzaida zhouzaida changed the base branch from refactor_hooks_unittest to main February 21, 2023 16:13
@zhouzaida zhouzaida merged commit 2dbc8ed into open-mmlab:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants