-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor checkpointhook unittest #789
[Refactor] Refactor checkpointhook unittest #789
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
=======================================
Coverage ? 76.69%
=======================================
Files ? 139
Lines ? 11035
Branches ? 2207
=======================================
Hits ? 8463
Misses ? 2209
Partials ? 363
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
30f11d5
to
32e2ef0
Compare
…eckpointhook_unittest
…eckpointhook_unittest
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
If the metric name contains
/
character, such as 'top10/acc', CheckpointHook will first create thebest_top10
directory and save the best checkpoint in it, which is not our expected:This PR will replace all
/
with_
to prevent from creating an unnecessary directory.Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist