Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix creating a new logger at PretrainedInit #791

Merged
merged 4 commits into from Dec 12, 2022
Merged

[Fix] Fix creating a new logger at PretrainedInit #791

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b2ea14
use current logger
xiexinch Dec 6, 2022
e7a25c0
remove get_current_instance
xiexinch Dec 6, 2022
884fcad
remove logger parameter at weight_init
xiexinch Dec 6, 2022
b267a16
remove elif branch
xiexinch Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmengine/model/weight_init.py
View file
Open in desktop
Expand Up @@ -481,7 +481,7 @@ def __call__(self, module):
from mmengine.runner.checkpoint import (_load_checkpoint_with_prefix,
load_checkpoint,
load_state_dict)
logger = MMLogger.get_instance('mmengine')
logger = MMLogger.get_current_instance()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can directly call print_log(xxx, logger='current') here, and do not need to get the current logger here.

if self.prefix is None:
print_log(f'load model from: {self.checkpoint}', logger=logger)
load_checkpoint(
Expand Down