Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix typos #814

Merged
merged 8 commits into from
Dec 11, 2022
Merged

[Docs] Fix typos #814

merged 8 commits into from
Dec 11, 2022

Conversation

shanmo
Copy link
Contributor

@shanmo shanmo commented Dec 11, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix typos

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@shanmo shanmo requested a review from C1rN09 as a code owner December 11, 2022 05:52
@shanmo shanmo changed the title Update model.md [Docs] Fix a typo in model.md Dec 11, 2022
@shanmo shanmo changed the title [Docs] Fix a typo in model.md [Docs] Fix typos in model.md Dec 11, 2022
@shanmo shanmo changed the title [Docs] Fix typos in model.md [Docs] Fix typos Dec 11, 2022
@zhouzaida
Copy link
Member

Hi @shanmo , thanks for your contribution. This PR can be merged after resolving the CI. You can follow the document to fix the lint issue.

@shanmo
Copy link
Contributor Author

shanmo commented Dec 11, 2022

Hi @shanmo , thanks for your contribution. This PR can be merged after resolving the CI. You can follow the document to fix the lint issue.

Sure, lint issues fixed, thanks

@zhouzaida zhouzaida merged commit be0bc3a into open-mmlab:main Dec 11, 2022
@shanmo shanmo deleted the patch-1 branch December 11, 2022 09:12
@openmmlab-bot
Copy link
Collaborator

Dear shanmo,
First of all, we want to express our gratitude for your significant PR in the MMEngine project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlabwx, or join in our discord:https://discord.gg/raweFPmdzG. We sincerely hope you will join us!
Best regards! @shanmo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants