Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] how to set the interval parameter #917

Merged
merged 9 commits into from Feb 14, 2023

Conversation

zhouzaida
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@74fcaea). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head d041173 differs from pull request most recent head daca86d. Consider uploading reports for the commit daca86d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage        ?   77.90%           
=======================================
  Files           ?      133           
  Lines           ?    10086           
  Branches        ?     2010           
=======================================
  Hits            ?     7857           
  Misses          ?     1888           
  Partials        ?      341           
Flag Coverage Δ
unittests 77.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

C1rN09
C1rN09 previously approved these changes Feb 13, 2023
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with some comments

docs/zh_cn/common_usage/set_interval.md Outdated Show resolved Hide resolved
docs/zh_cn/common_usage/set_interval.md Show resolved Hide resolved
mmengine/runner/utils.py Show resolved Hide resolved
zhouzaida and others added 3 commits February 13, 2023 16:45
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
@zhouzaida zhouzaida merged commit 502edec into open-mmlab:main Feb 14, 2023
@zhouzaida zhouzaida deleted the how-to-set-interval branch February 14, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants