Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] MessageHub.get_info() supports returning a default value #991

Merged
merged 22 commits into from Apr 23, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Mar 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Reslove #988

Modification

Reslove #988

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@enkilee enkilee requested a review from HAOCHENYE as a code owner March 10, 2023 03:11
mmengine/logging/message_hub.py Outdated Show resolved Hide resolved
mmengine/logging/message_hub.py Outdated Show resolved Hide resolved
mmengine/logging/message_hub.py Outdated Show resolved Hide resolved
mmengine/logging/message_hub.py Outdated Show resolved Hide resolved
@HAOCHENYE
Copy link
Collaborator

HAOCHENYE commented Mar 13, 2023

Hi! The CI seems failed. We should also update the unit test to make sure the correctness of this PR.

@enkilee enkilee requested a review from zhouzaida as a code owner March 13, 2023 08:31
@zhouzaida zhouzaida changed the title fix issue 988 [Enhancement] MessageHub.get_info() supports returning a default value Mar 13, 2023
@HAOCHENYE
Copy link
Collaborator

Hi, the CI seems failed, please fix it

image

@enkilee
Copy link
Contributor Author

enkilee commented Mar 20, 2023

Hi, the CI seems failed, please fix it

image

ok
pc is using for remoter, i will fix it asap

@zhouzaida zhouzaida added this to the 0.7.3 milestone Apr 21, 2023
zhouzaida
zhouzaida previously approved these changes Apr 23, 2023
tests/test_logging/test_message_hub.py Outdated Show resolved Hide resolved
tests/test_logging/test_message_hub.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit 0687b37 into open-mmlab:main Apr 23, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] MessageHub.get_info() supports returning a default value if the key doesn't exit
3 participants