Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix AMP in Ascend and support using NPUJITCompile environment #994

Merged
merged 2 commits into from Mar 13, 2023

Conversation

luomaoling
Copy link
Contributor

@luomaoling luomaoling commented Mar 13, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. Support automatic mixed-precision training with pytorch version 1.10 or above.
  2. Support manually set up the use of dynamic shapes and static shapes.

Modification

  1. mmengine/runner/amp.py. complements to NPU autocast.
  2. mmengine/device/utils.py. supplemented with a switch to turn on static shape,dynamic shapes are used by default.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
None.

Use cases (Optional)

Open the static shape:export NPUJITCompile=True

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@luomaoling luomaoling changed the title Npu autoamp [Fix] Npu autoamp Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0d25625). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 2df4355 differs from pull request most recent head 4c5e458. Consider uploading reports for the commit 4c5e458 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage        ?   76.57%           
=======================================
  Files           ?      139           
  Lines           ?    11037           
  Branches        ?     2207           
=======================================
  Hits            ?     8452           
  Misses          ?     2219           
  Partials        ?      366           
Flag Coverage Δ
unittests 76.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wangjiangben-hw
Copy link
Contributor

/lgtm

@luomaoling
Copy link
Contributor Author

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Supplement the support of some functions on the NPU.

Modification

1.mmengine/runner/amp.py. complements to NPU autocast. 2.mmengine/device/utils.py. supplemented with a switch to turn on static shape.

@luomaoling luomaoling closed this Mar 13, 2023
@luomaoling luomaoling reopened this Mar 13, 2023
@luomaoling luomaoling changed the title [Fix] Npu autoamp [Fix] Npu autoamp add NPUJITCompile Mar 13, 2023
@luomaoling luomaoling changed the title [Fix] Npu autoamp add NPUJITCompile [Fix] Fix npu autoamp add NPUJITCompile Mar 13, 2023
@luomaoling luomaoling changed the title [Fix] Fix npu autoamp add NPUJITCompile [Fix] Fix npu amp add NPUJITCompile Mar 13, 2023
@zhouzaida zhouzaida changed the title [Fix] Fix npu amp add NPUJITCompile [Fix] Fix AMP in Ascend and support using NPUJITCompile environment Mar 13, 2023
@zhouzaida zhouzaida merged commit 8177ef2 into open-mmlab:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants