Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] CircleCI fail due to plum-dispatch v2.0.0 #108

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

C1rN09
Copy link
Collaborator

@C1rN09 C1rN09 commented Mar 7, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

plum-dispatch bumps to version 2.0.0 yesterday, which breaks our unittests. There are 2 issues:

1. name 'xxx' is not defined

image

Reson: Still under investigation.

2. TypeError: unhashable type: 'list'

image

Reason: plum-dispatch 2.0.0 migrates to use beartype, while beartype doesn't support Python 3.9.1. This is actually a CPython error fixed in Python 3.9.2.

Modification

Restrict plum-dispatch<2.0.0 in requirements. Once fixed, will remove the version restriction.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@C1rN09 C1rN09 requested a review from zhouzaida as a code owner March 7, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants