Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] make scipy as a runtime dependency #109

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

C1rN09
Copy link
Collaborator

@C1rN09 C1rN09 commented Mar 8, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

scipy has been used in some metrics:

  • hmean_iou
  • niqe
  • ms_ssim (upcoming)

Therefore, we should make it a runtime dependency instead of an optional dependency.

Modification

As in PR

BC-breaking (Optional)

No

Use cases (Optional)

No

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@C1rN09 C1rN09 requested a review from zhouzaida as a code owner March 8, 2023 09:07
@zhouzaida zhouzaida merged commit 9f01f47 into open-mmlab:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants