Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oneflow backend for mmeval #58

Merged
merged 15 commits into from
Dec 7, 2022
Merged

add oneflow backend for mmeval #58

merged 15 commits into from
Dec 7, 2022

Conversation

ofhwei
Copy link
Contributor

@ofhwei ofhwei commented Nov 30, 2022

Motivation

add oneflow backend for mmeval.

Modification

add the following metrics and unittests in oneflow:

  • accuracy
  • end_point_error
  • f_metric
  • mean_iou
  • multi_label
  • single_label

ice-tong
ice-tong reviewed Dec 2, 2022
View reviewed changes
mmeval/metrics/end_point_error.py Outdated Show resolved Hide resolved
mmeval/metrics/end_point_error.py Outdated Show resolved Hide resolved
mmeval/metrics/mean_iou.py Outdated Show resolved Hide resolved
mmeval/metrics/multi_label.py Show resolved Hide resolved
mmeval/metrics/single_label.py Outdated Show resolved Hide resolved
tests/test_metrics/test_multi_label.py Outdated Show resolved Hide resolved
tests/test_metrics/test_multi_label.py Outdated Show resolved Hide resolved
@ofhwei ofhwei mentioned this pull request Dec 4, 2022
Merged
@zhouzaida
Copy link
Member

#59 has been merged and please update this PR with the main branch to trigger the CI tests.

ice-tong
ice-tong approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 4 comments

mmeval/metrics/end_point_error.py Outdated Show resolved Hide resolved
mmeval/metrics/multi_label.py Outdated Show resolved Hide resolved
mmeval/metrics/multi_label.py Show resolved Hide resolved
tests/test_metrics/test_single_label_metric.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit 2935dbe into open-mmlab:main Dec 7, 2022
@ofhwei ofhwei deleted the add_oneflow_backend branch December 7, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice-tong ice-tong ice-tong approved these changes

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofhwei @zhouzaida @ice-tong