Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp #1538] Add GradientError #78

Merged
merged 17 commits into from
Jan 15, 2023

Conversation

xuan07472
Copy link
Contributor

@xuan07472 xuan07472 commented Jan 12, 2023

Motivation

Add MattingMSE of MMEditing to MMEval and complete the adaptation.

Modification

Add MattingMSE of GradientError to MMEval
The PR link using mmeval.GradientError in mmediting:open-mmlab/mmagic#1598 (comment)

mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 3 comments

mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
mmeval/metrics/gradient_error.py Outdated Show resolved Hide resolved
update

Co-authored-by: yancong <32220263+ice-tong@users.noreply.github.com>
docs/en/api/metrics.rst Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit d14a5ef into open-mmlab:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants