Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add CharRecallPrecision for OCR Task #96

Merged
merged 6 commits into from
Mar 14, 2023
Merged

[Feature] Add CharRecallPrecision for OCR Task #96

merged 6 commits into from
Mar 14, 2023

Conversation

Harold-lkk
Copy link
Contributor

@Harold-lkk Harold-lkk commented Feb 15, 2023 •
edited
Loading

@Harold-lkk Harold-lkk force-pushed the lkk/CharRecallPrecision branch 2 times, most recently from 753a303 to 12d5b6b Compare February 15, 2023 09:44
@Harold-lkk Harold-lkk mentioned this pull request Feb 15, 2023
Open
C1rN09
C1rN09 reviewed Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add api docs

mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
tests/test_metrics/test_char_recall_precision.py Outdated Show resolved Hide resolved
C1rN09
C1rN09 reviewed Feb 17, 2023
View reviewed changes
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
@Harold-lkk Harold-lkk force-pushed the lkk/CharRecallPrecision branch 2 times, most recently from fb98732 to 885d5f1 Compare February 28, 2023 07:06
C1rN09
C1rN09 reviewed Mar 2, 2023
View reviewed changes
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
mmeval/metrics/char_recall_precision.py Outdated Show resolved Hide resolved
@Harold-lkk Harold-lkk requested a review from C1rN09 March 6, 2023 02:30
C1rN09
C1rN09 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should rebase to main branch to fix CI

@zhouzaida zhouzaida merged commit a9cf49b into open-mmlab:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@C1rN09 C1rN09 C1rN09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Harold-lkk @zhouzaida @C1rN09