Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Bug fixes in data converters and transforms #69

Merged
merged 15 commits into from Jan 20, 2022

Conversation

pangyyyyy
Copy link
Collaborator

@pangyyyyy pangyyyyy commented Jan 6, 2022

Resolves #67

  • Inplace renaming operation to obtain correct image path in agora converter
  • Use tuple instead of string check in agora converter
  • Retrieve correct image path using id in posetrack converter
  • Fix inconsistency is cv2.inwrite image path and stored image path in surreal converter
  • Fix H36M cam_param to store a dictionary of camera parameters

Resolves #70

  • Fix type in instances where bbox_xywh is bbox_xyxy
  • Split _bbox_expand to bbox_expand (only bbox expansion) and xyxy2xywh (xyxy conversion to xywh)

Resolves #79 issue of keypoints2d_loss not converging

  • Make a copy of keypoints2d instead of directly modifying when applying augmentations

Resolves #49 .

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #69 (43ae21d) into main (03f6ebf) will increase coverage by 0.43%.
The diff coverage is 82.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   83.44%   83.87%   +0.43%     
==========================================
  Files         162      162              
  Lines       12162    12179      +17     
==========================================
+ Hits        10148    10215      +67     
+ Misses       2014     1964      -50     
Flag Coverage Δ
unittests 83.87% <82.69%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/data/datasets/pipelines/transforms.py 43.93% <0.00%> (ø)
mmhuman3d/data/data_converters/surreal.py 89.78% <66.66%> (+0.07%) ⬆️
mmhuman3d/data/data_converters/agora.py 91.54% <100.00%> (+0.76%) ⬆️
mmhuman3d/data/data_converters/base_converter.py 89.65% <100.00%> (+1.65%) ⬆️
mmhuman3d/data/data_converters/h36m.py 94.52% <100.00%> (+18.94%) ⬆️
mmhuman3d/data/data_converters/h36m_spin.py 89.13% <100.00%> (+0.07%) ⬆️
mmhuman3d/data/data_converters/humman.py 95.80% <100.00%> (+0.02%) ⬆️
mmhuman3d/data/data_converters/insta_vibe.py 98.14% <100.00%> (+0.03%) ⬆️
mmhuman3d/data/data_converters/lsp.py 94.64% <100.00%> (+0.09%) ⬆️
mmhuman3d/data/data_converters/lsp_extended.py 94.00% <100.00%> (+0.12%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f6ebf...43ae21d. Read the comment docs.

@caizhongang
Copy link
Collaborator

caizhongang commented Jan 7, 2022

Please link the issue from which the PR is originated. The syntax may be Resolves #xx such that the issue is automatically closed when PR is merged. Please also add prefix such as [Fix] in the PR title.

@pangyyyyy pangyyyyy changed the title Converters bug fix [Fix] Converters bug fix Jan 7, 2022
@pangyyyyy
Copy link
Collaborator Author

Please link the issue from which the PR is originated. The syntax may be Resolves #xx such that the issue is automatically closed when PR is merged. Please also add prefix such as [Fix] in the PR title.

@caizhongang done!

Copy link
Collaborator

@caizhongang caizhongang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current changes are fine. And please also include #70 in this PR.

@pangyyyyy pangyyyyy changed the title [Fix] Converters bug fix [Fix] Bug fixes Jan 19, 2022
@caizhongang
Copy link
Collaborator

Please also link this issue in the PR description #79.

@caizhongang caizhongang self-assigned this Jan 19, 2022
@caizhongang caizhongang changed the title [Fix] Bug fixes [Fix] Bug fixes in data converters and transforms Jan 19, 2022
@pangyyyyy
Copy link
Collaborator Author

Please also link this issue in the PR description #79.

done!

@caizhongang
Copy link
Collaborator

I think #49 is also related to data, shall we resolve it here also? (i.e. add the links in the readme)

@pangyyyyy
Copy link
Collaborator Author

I think #49 is also related to data, shall we resolve it here also? (i.e. add the links in the readme)

Added in 3749a84

@caizhongang caizhongang self-requested a review January 20, 2022 05:54
@caizhongang caizhongang merged commit b84d9a0 into open-mmlab:main Jan 20, 2022
ttxskk pushed a commit that referenced this pull request Jun 17, 2022
Resolves #67 
- Inplace renaming operation to obtain correct image path in agora converter
- Use tuple instead of string check in agora converter
- Retrieve correct image path using id in posetrack converter
- Fix inconsistency is cv2.inwrite image path and stored image path in surreal converter
- Fix H36M cam_param to store a dictionary of camera parameters

Resolves #70 
- Fix type in instances where `bbox_xywh` is `bbox_xyxy`
- Split `_bbox_expand` to `bbox_expand` (only bbox expansion) and `xyxy2xywh` (xyxy conversion to xywh)

Resolves #79 issue of `keypoints2d_loss` not converging
- Make a copy of keypoints2d instead of directly modifying when applying augmentations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants