Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support modified resnet structure used in oCLIP #1458

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

HannibalAPE
Copy link
Contributor

@HannibalAPE HannibalAPE commented Oct 14, 2022

Motivation

To support modified resnet structure used in oCLIP, which is also the official structure in CLIP.
Currently, I only implement CLIPResNet-50 when depth=50. CLIPResNet-101 would be implemented later.
We also provide a script for converting the parameter names of our models to MMOCR style.

For more information, please refer to oCLIP

Modification

Add a new ResNet structure, named as CLIPResNet in mmocr/models/common/backbones/clip_resnet.py

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2022

CLA assistant check
All committers have signed the CLA.

@Harold-lkk Harold-lkk self-requested a review October 30, 2022 07:59
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/plugins/common.py Outdated Show resolved Hide resolved
mmocr/models/common/plugins/common.py Outdated Show resolved Hide resolved
mmocr/models/common/plugins/common.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/plugins/common.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/backbones/clip_resnet.py Outdated Show resolved Hide resolved
mmocr/models/common/plugins/common.py Outdated Show resolved Hide resolved
@gaotongxiao gaotongxiao merged commit f1dd437 into open-mmlab:dev-1.x Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants