Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make lanms-neo optional #1772

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

gaotongxiao
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

lanms-neo has long been complained to block the installation on some edge devices, but it is only required by DRRG as of now and removing it from requirements does not seem to make a significant impact in the future.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.07 ⚠️

Comparison is base (75c06d3) 89.82% compared to head (464d011) 89.76%.

❗ Current head 464d011 differs from pull request most recent head d7f728c. Consider uploading reports for the commit d7f728c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1772      +/-   ##
===========================================
- Coverage    89.82%   89.76%   -0.07%     
===========================================
  Files          191      191              
  Lines        11218    11228      +10     
  Branches      1582     1584       +2     
===========================================
+ Hits         10077    10079       +2     
- Misses         832      838       +6     
- Partials       309      311       +2     
Flag Coverage Δ
unittests 89.76% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/models/textdet/heads/drrg_head.py 98.83% <33.33%> (-0.78%) ⬇️
...r/models/textdet/module_losses/drrg_module_loss.py 95.89% <33.33%> (-1.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit 47f5430 into open-mmlab:dev-1.x Mar 10, 2023
@gaotongxiao gaotongxiao deleted the lanms-neo branch March 10, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants