[Feature] Adaptive wingloss (ICCV'19) #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev-0.22 #1072 +/- ##
===========================================
Coverage ? 82.47%
===========================================
Files ? 203
Lines ? 16078
Branches ? 2864
===========================================
Hits ? 13260
Misses ? 2095
Partials ? 723
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jin-s13
changed the title
jin-s13
removed
BLOCK BY ACCURACY VERIFICATION
need doc
status/WIP
ly015
reviewed
Dec 15, 2021
| @@ -159,7 +159,7 @@ def get_loss(self, output, target, target_weight): | |||
|
|
|||
| assert not isinstance(self.loss, nn.Sequential) | |||
| assert target.dim() == 4 and target_weight.dim() == 3 | |||
| losses['mse_loss'] = self.loss(output, target, target_weight) | |||
| losses['heatmap_loss'] = self.loss(output, target, target_weight) | |||
There was a problem hiding this comment.
Will this lead to risks of bc breaking?
There was a problem hiding this comment.
OK, we can mention it in the changelog.
ly015
reviewed
Dec 15, 2021
|
|
||
| @LOSSES.register_module() | ||
| class AdaptiveWingLoss(nn.Module): | ||
| """Adaptive wing loss. paper ref: 'Adaptive Wing Loss for Robust Face |
There was a problem hiding this comment.
Please follow standard reference format:
mmpose/mmpose/models/backbones/hrnet.py
Lines 218 to 219 in 228747c
ly015
force-pushed
the
adaptive_wingloss
branch
from
0fd1ebc
to
25340d6
Compare
ly015
approved these changes
Dec 17, 2021
6 tasks
ly015
added a commit
that referenced
this pull request
Jan 4, 2022
* add adaptive wingloss * move adaptive wingloss to heatmap_loss * match shape in wingloss * rename loss * mean for loss * add configs * fix unittest * rename mse_loss to heatmap_loss * add docs * fix lint Co-authored-by: ly015 <liyining0712@gmail.com>
ly015
added a commit
that referenced
this pull request
Jan 5, 2022
* add adaptive wingloss * move adaptive wingloss to heatmap_loss * match shape in wingloss * rename loss * mean for loss * add configs * fix unittest * rename mse_loss to heatmap_loss * add docs * fix lint Co-authored-by: ly015 <liyining0712@gmail.com>
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
* add adaptive wingloss * move adaptive wingloss to heatmap_loss * match shape in wingloss * rename loss * mean for loss * add configs * fix unittest * rename mse_loss to heatmap_loss * add docs * fix lint Co-authored-by: ly015 <liyining0712@gmail.com>
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
* add adaptive wingloss * move adaptive wingloss to heatmap_loss * match shape in wingloss * rename loss * mean for loss * add configs * fix unittest * rename mse_loss to heatmap_loss * add docs * fix lint Co-authored-by: ly015 <liyining0712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support Adaptive Wing Loss.
Modification
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: