Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support circleci and fix lint check #1074

Merged
merged 7 commits into from
Dec 9, 2021

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Dec 8, 2021

Motivation

Modification

  • Add .circleci/config.yml
  • Add .github/workflows/lint.yml
  • Modify .github/workflows/built.yml' to remove lint check
  • Modify .pre-commit-config.yaml to use offical markdownlint hook

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev-0.22@4297d1e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             dev-0.22    #1074   +/-   ##
===========================================
  Coverage            ?   83.39%           
===========================================
  Files               ?      196           
  Lines               ?    15142           
  Branches            ?     2736           
===========================================
  Hits                ?    12627           
  Misses              ?     1823           
  Partials            ?      692           
Flag Coverage Δ
unittests 83.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4297d1e...98f83ab. Read the comment docs.

@ly015 ly015 changed the title [Enhancement] Support circleci [WIP] [Enhancement] Support circleci Dec 8, 2021
@ly015 ly015 changed the title [Enhancement] Support circleci [Enhancement] Support circleci and fix lint check Dec 8, 2021
@ly015 ly015 removed the need tests label Dec 9, 2021
@ly015 ly015 requested a review from jin-s13 December 9, 2021 03:18
@jin-s13 jin-s13 requested a review from innerlee December 9, 2021 05:02
@ly015 ly015 merged commit 434836c into open-mmlab:dev-0.22 Dec 9, 2021
ly015 added a commit to ly015/mmpose that referenced this pull request Dec 17, 2021
* use offical markdownlint hook

* add lint.yml

* add circleci config

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml
ly015 added a commit that referenced this pull request Jan 4, 2022
* use offical markdownlint hook

* add lint.yml

* add circleci config

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml
ly015 added a commit that referenced this pull request Jan 5, 2022
* use offical markdownlint hook

* add lint.yml

* add circleci config

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* use offical markdownlint hook

* add lint.yml

* add circleci config

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
…n BaseMetric (open-mmlab#1074)

* [Enhance] Support configuring synchronize directory for BaseMetric

* Raise error if tmpdir is not an shared dirctory for ann ranks

* Raise error if tmpdir is not an shared dirctory for ann ranks

* Update mmengine/evaluator/metric.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

* refine

* Update mmengine/evaluator/metric.py

---------

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* use offical markdownlint hook

* add lint.yml

* add circleci config

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants