Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Soft wing loss (TIP'2021) #1077

Merged
merged 4 commits into from
Dec 17, 2021
Merged

[Feature] Soft wing loss (TIP'2021) #1077

merged 4 commits into from
Dec 17, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Dec 9, 2021 •
edited
Loading

Motivation

Support SoftWingLoss.
"Structure-Coherent Deep Feature Learning for Robust Face Alignment" TIP'2021

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@jin-s13 jin-s13 changed the base branch from master to dev-0.22 December 9, 2021 08:54
@jin-s13 jin-s13 changed the title Soft wing loss [Feature] Soft wing loss Dec 9, 2021
@jin-s13 jin-s13 changed the title [Feature] Soft wing loss [Feature] Soft wing loss (TIP'2021) Dec 9, 2021
@jin-s13 jin-s13 requested a review from ly015 December 12, 2021 09:41
ly015
ly015 reviewed Dec 15, 2021
View reviewed changes
mmpose/models/losses/regression_loss.py
@@ -117,6 +118,84 @@ def forward(self, output, target, target_weight=None):
return loss * self.loss_weight


@LOSSES.register_module()
class SoftWingLoss(nn.Module):
"""Soft Wing Loss 'Structure-Coherent Deep Feature Learning for Robust Face
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the standard reference format:

mmpose/mmpose/models/backbones/hrnet.py

Lines 218 to 219 in 228747c

`High-Resolution Representations for Labeling Pixels and Regions
<https://arxiv.org/abs/1904.04514>`__

@ly015 ly015 merged commit 7c92f0e into dev-0.22 Dec 17, 2021
This was referenced Dec 17, 2021
Closed
Merged
@jin-s13 jin-s13 deleted the smooth_wing_loss branch December 27, 2021 06:35
ly015 pushed a commit that referenced this pull request Jan 4, 2022
@jin-s13 @ly015
[Feature] Soft wing loss (TIP'2021) (#1077)
169af02 
* support soft_wing_loss

* add unittest for soft wing loss

* update model md

* update doc
ly015 pushed a commit that referenced this pull request Jan 5, 2022
@jin-s13 @ly015
[Feature] Soft wing loss (TIP'2021) (#1077)
ff55efe 
* support soft_wing_loss

* add unittest for soft wing loss

* update model md

* update doc
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@jin-s13 @ly015
[Feature] Soft wing loss (TIP'2021) (open-mmlab#1077)
c8e6d6c 
* support soft_wing_loss

* add unittest for soft wing loss

* update model md

* update doc
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
@jin-s13 @ly015
[Feature] Soft wing loss (TIP'2021) (open-mmlab#1077)
d0b10bb 
* support soft_wing_loss

* add unittest for soft wing loss

* update model md

* update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly015 ly015 ly015 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jin-s13 @ly015