Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Don't destroy NULL windows if args.show == False #1104

Merged
merged 1 commit into from
Dec 26, 2021

Conversation

bladrome
Copy link
Contributor

Motivation

Run the demo code in remote machine without cam.

Modification

Add args.show checking in demo/foo.py

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2021

CLA assistant check
All committers have signed the CLA.

@ly015 ly015 changed the title Fix: Don't destroy NULL windows if args.show == False [Fix] Don't destroy NULL windows if args.show == False Dec 26, 2021
@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #1104 (2397c77) into master (bf691c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files         196      196           
  Lines       15142    15142           
  Branches     2736     2736           
=======================================
  Hits        12627    12627           
  Misses       1823     1823           
  Partials      692      692           
Flag Coverage Δ
unittests 83.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf691c0...2397c77. Read the comment docs.

@ly015 ly015 merged commit a9053b1 into open-mmlab:master Dec 26, 2021
@OpenMMLab-Assistant003
Copy link

Hi @bladrome!First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @bladrome

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants