Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] refactor multiview humanpose #1196

Merged
merged 15 commits into from Mar 7, 2022
Merged

[Refactor] refactor multiview humanpose #1196

merged 15 commits into from Mar 7, 2022

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Feb 16, 2022

Motivation

Re-organize the framework of VoxelPose into a more general detect-and-regress approach.

Modification

mmpose/models/detectors/multiview_pose.py
tests/test_models/test_multiview_pose.py

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ liqikai9
❌ wusize


wusize seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wusize wusize requested a review from jin-s13 February 16, 2022 03:44
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1196 (87ff3e9) into master (4b4822c) will increase coverage by 0.75%.
The diff coverage is 69.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   82.25%   83.01%   +0.75%     
==========================================
  Files         204      204              
  Lines       16193    16192       -1     
  Branches     2891     2892       +1     
==========================================
+ Hits        13319    13441     +122     
+ Misses       2143     2012     -131     
- Partials      731      739       +8     
Flag Coverage Δ
unittests 82.94% <69.14%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/detectors/multiview_pose.py 69.04% <67.85%> (ø)
mmpose/models/detectors/__init__.py 100.00% <100.00%> (ø)
mmpose/models/heads/voxelpose_head.py 100.00% <100.00%> (+2.98%) ⬆️
mmpose/core/visualization/__init__.py 100.00% <0.00%> (ø)
mmpose/datasets/pipelines/shared_transform.py 81.57% <0.00%> (+0.43%) ⬆️
mmpose/core/distributed_wrapper.py 42.10% <0.00%> (+4.96%) ⬆️
mmpose/core/visualization/effects.py 90.00% <0.00%> (+47.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662cb50...87ff3e9. Read the comment docs.

@jin-s13 jin-s13 requested review from liqikai9 and ly015 and removed request for liuxin9608 February 16, 2022 14:09
@jin-s13
Copy link
Collaborator

jin-s13 commented Feb 17, 2022

Need more detailed code comments.

@@ -115,12 +115,11 @@
type='V2VNet', input_channels=num_joints, output_channels=1),
center_head=dict(
type='CuboidCenterHead',
cfg=dict(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config should be consistent with the model definition, for example, the type of model here should be DetectAndRegress instead of VoxelPose. Check other fields that need to be modified.

mmpose/models/detectors/multiview_pose.py Outdated Show resolved Hide resolved
mmpose/models/detectors/multiview_pose.py Show resolved Hide resolved
mmpose/models/detectors/multiview_pose.py Outdated Show resolved Hide resolved
@ly015 ly015 changed the title Multiview humanpose [Refactor] Multiview humanpose Mar 1, 2022
@ly015 ly015 changed the title [Refactor] Multiview humanpose [Refactor] refactor multiview humanpose Mar 1, 2022
@ly015 ly015 changed the base branch from master to dev-0.24 March 1, 2022 07:07
@ly015
Copy link
Member

ly015 commented Mar 1, 2022

@wusize @jin-s13 The codecov rate is below the target. Do we need to work on it?

@jin-s13
Copy link
Collaborator

jin-s13 commented Mar 2, 2022

@wusize @jin-s13 The codecov rate is below the target. Do we need to work on it?

I think this PR can be merged, as codecov/project look good.

@ly015 ly015 merged commit 3d676a5 into dev-0.24 Mar 7, 2022
ly015 pushed a commit that referenced this pull request Mar 7, 2022
* 'multiview_pose'

* 'single_pose'

* multiview_pose_detect_and_regress

* unit test

* typo

* typo

* unit test

* del old codes

* del old codes

* 'fix_test_bug'

* 'accuray_test'

* fix input_heatmaps

* stay consistent with official voxelpose model keys

* fix lint

* add comments

Co-authored-by: wusize <wusize@sensetime.com>
Co-authored-by: liqikai <tiger19971215@sjtu.edu.cn>
@jin-s13 jin-s13 deleted the multiview_humanpose branch April 27, 2022 09:32
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* 'multiview_pose'

* 'single_pose'

* multiview_pose_detect_and_regress

* unit test

* typo

* typo

* unit test

* del old codes

* del old codes

* 'fix_test_bug'

* 'accuray_test'

* fix input_heatmaps

* stay consistent with official voxelpose model keys

* fix lint

* add comments

Co-authored-by: wusize <wusize@sensetime.com>
Co-authored-by: liqikai <tiger19971215@sjtu.edu.cn>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* 'multiview_pose'

* 'single_pose'

* multiview_pose_detect_and_regress

* unit test

* typo

* typo

* unit test

* del old codes

* del old codes

* 'fix_test_bug'

* 'accuray_test'

* fix input_heatmaps

* stay consistent with official voxelpose model keys

* fix lint

* add comments

Co-authored-by: wusize <wusize@sensetime.com>
Co-authored-by: liqikai <tiger19971215@sjtu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants