Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add deprecation message for deploy tools #1207

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

QwQ2000
Copy link
Contributor

@QwQ2000 QwQ2000 commented Feb 24, 2022

Motivation

Since MMDeploy has been released, the deployment tools scattered in each OpenMMLab codebase will be deprecated in future.

Modification

Add deprecation message in deployment tools.
Used package colorama to print cross-platform colored text.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev-0.24@9b3baea). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             dev-0.24    #1207   +/-   ##
===========================================
  Coverage            ?   82.49%           
===========================================
  Files               ?      204           
  Lines               ?    16144           
  Branches            ?     2886           
===========================================
  Hits                ?    13318           
  Misses              ?     2096           
  Partials            ?      730           
Flag Coverage Δ
unittests 82.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3baea...6cadba0. Read the comment docs.

@ly015 ly015 merged commit f64a14d into open-mmlab:dev-0.24 Feb 28, 2022
@ly015 ly015 changed the title Add deprecation message for deploy tools [Fix] Add deprecation message for deploy tools Mar 2, 2022
ly015 pushed a commit that referenced this pull request Mar 7, 2022
* add derepcation message for deploy tools

* change import warnings positions

* do yapf

* do isort
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add derepcation message for deploy tools

* change import warnings positions

* do yapf

* do isort
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* add derepcation message for deploy tools

* change import warnings positions

* do yapf

* do isort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants