Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update required xtcocotools version to v1.12 #1308

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Apr 11, 2022

Motivation

Update required xtcocotools version to v1.12, which fixed a bug reported in #1280 .

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1308 (76ac6c4) into master (2ea8ee6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1308   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         215      215           
  Lines       17674    17674           
  Branches     3139     3139           
=======================================
+ Hits        14864    14865    +1     
  Misses       2018     2018           
+ Partials      792      791    -1     
Flag Coverage Δ
unittests 84.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/pipelines/shared_transform.py 81.57% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e20dc...76ac6c4. Read the comment docs.

@ly015 ly015 merged commit a8dbc1c into master Apr 11, 2022
@jin-s13 jin-s13 deleted the update-xtcocotools-version branch April 27, 2022 09:32
ly015 added a commit to chenxinfeng4/mmpose that referenced this pull request May 5, 2022
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant