-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Move bbox conversion (xywh2cs) from datasets to pipeline #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev-0.26 #1311 +/- ##
============================================
- Coverage 84.10% 84.09% -0.01%
============================================
Files 215 217 +2
Lines 17674 17701 +27
Branches 3139 3145 +6
============================================
+ Hits 14865 14886 +21
- Misses 2018 2021 +3
- Partials 791 794 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ly015
commented
Apr 28, 2022
jin-s13
approved these changes
May 2, 2022
ly015
added a commit
that referenced
this pull request
May 5, 2022
…1311) * add TopDownGetBboxCenterScale transform * update topdown coco * update topdown aic * update coco deeppose and coco-wholebody * update topdown crowdpose * update halpe/jhmdb/h36m * update mhp/ochuman/posetrack18 * update mhp/ochuman/posetrack18 * update all datasets * add unittest * remove irrelevant files * refactor inference apis * separate xywh2cs and random shift * update configs * update mpii configs * add create_ceph_configs * fix typo * minor fix * fix unittest * fix coco-wholebody-dataset * fix typos in configs * fix posetrack18 configs * fix posetrack18 configs * delete config with bboxshift * modify accuracy records of Halpe * update accuracy of AP10k * update colab tutorial and unittest * rename _do_keypoint_eval->_do_python_keypoint_eval Co-authored-by: lupeng <penglu2097@gmail.com>
This was referenced May 5, 2022
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
…pen-mmlab#1311) * add TopDownGetBboxCenterScale transform * update topdown coco * update topdown aic * update coco deeppose and coco-wholebody * update topdown crowdpose * update halpe/jhmdb/h36m * update mhp/ochuman/posetrack18 * update mhp/ochuman/posetrack18 * update all datasets * add unittest * remove irrelevant files * refactor inference apis * separate xywh2cs and random shift * update configs * update mpii configs * add create_ceph_configs * fix typo * minor fix * fix unittest * fix coco-wholebody-dataset * fix typos in configs * fix posetrack18 configs * fix posetrack18 configs * delete config with bboxshift * modify accuracy records of Halpe * update accuracy of AP10k * update colab tutorial and unittest * rename _do_keypoint_eval->_do_python_keypoint_eval Co-authored-by: lupeng <penglu2097@gmail.com>
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
…pen-mmlab#1311) * add TopDownGetBboxCenterScale transform * update topdown coco * update topdown aic * update coco deeppose and coco-wholebody * update topdown crowdpose * update halpe/jhmdb/h36m * update mhp/ochuman/posetrack18 * update mhp/ochuman/posetrack18 * update all datasets * add unittest * remove irrelevant files * refactor inference apis * separate xywh2cs and random shift * update configs * update mpii configs * add create_ceph_configs * fix typo * minor fix * fix unittest * fix coco-wholebody-dataset * fix typos in configs * fix posetrack18 configs * fix posetrack18 configs * delete config with bboxshift * modify accuracy records of Halpe * update accuracy of AP10k * update colab tutorial and unittest * rename _do_keypoint_eval->_do_python_keypoint_eval Co-authored-by: lupeng <penglu2097@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the bbox conversion is done in datasets, which may have the following drawbacks:
bbox
andcenter
+scale
, which may be confusing.Modification
xywh2cs
operation from top-down datasets. Data samples obtained from the dataset no longer havecenter
andscale
fields, but onlybbox
TopDownGetBboxCenterScale
to convertbbox
tocenter
andscale
. Optionally, apply padding and random shift to the bbox (Same function as originalxywh2cs
).TopDownRandomTranslation
data transform which has redundant functions and is rarely used.BC-breaking (Optional)
Use cases (Optional)
Usage of
TopDownGetBboxCenterScale
:Usage of
create_ceph_config.py
Run the following command to create a copy of
configs
atconfigs_ceph
with the ceph data backend properly set.# python .dev_scripts/develop/create_ceph_configs.py <USER_BUCKET> [--work-dir-prefix <WORK_DIR_PREFIX>] python .dev_scripts/develop/create_ceph_configs.py liyining --work-dir-prefix work_dirs
Model Verification
Criterions
Progress
hrnet_dark_coco
hrnet_udp_coco
hrnet_dark_mpii
hrnet_udp_mpii deeppose_resnet_mpii
2. new configs:
*_bboxshift.py
inconfigs/body/2d_kpt_sview_rgb_img/topdown_heatmap/mpii
hrnetv2_wflw
hrnetv2_dark_wflw
hrnetv2_awing_wflw
2. new configs:
*_bboxshift.py
inconfigs/face/2d_kpt_sview_rgb_img/deeppose/wflw
3. new configs:
*_bboxshift.py
inconfigs/face/2d_kpt_sview_rgb_img/topdown_heatmap/wflw
All Related Datasets
Checklist
Before PR:
After PR: