Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bug of human skeleton grouping for params.ignore_too_much #1341

Merged
merged 1 commit into from May 2, 2022
Merged

[Fix] Fix bug of human skeleton grouping for params.ignore_too_much #1341

merged 1 commit into from May 2, 2022

Conversation

daixinghome
Copy link
Contributor

@daixinghome daixinghome commented Apr 27, 2022

Motivation

Fix: #1336

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2022

CLA assistant check
All committers have signed the CLA.

@daixinghome daixinghome changed the title fix bug of human skeleton grouping for params.ignore_too_much [Fix] Fix bug of human skeleton grouping for params.ignore_too_much Apr 27, 2022
@ly015 ly015 requested a review from jin-s13 April 27, 2022 05:24
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1341 (cfa2e03) into master (11a3e35) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   84.12%   84.16%   +0.04%     
==========================================
  Files         215      215              
  Lines       17689    17692       +3     
  Branches     3144     3145       +1     
==========================================
+ Hits        14880    14891      +11     
+ Misses       2018     2013       -5     
+ Partials      791      788       -3     
Flag Coverage Δ
unittests 84.10% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/core/post_processing/group.py 87.86% <100.00%> (+4.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a3e35...cfa2e03. Read the comment docs.

@jin-s13
Copy link
Collaborator

jin-s13 commented Apr 27, 2022

Thank you for your contribution! @daixinghome
It seems that the lint check fails. Would you mind following the https://github.com/open-mmlab/mmpose/blob/master/.github/CONTRIBUTING.md to setup the pre-commit?

@daixinghome
Copy link
Contributor Author

Thank you for your contribution! @daixinghome It seems that the lint check fails. Would you mind following the https://github.com/open-mmlab/mmpose/blob/master/.github/CONTRIBUTING.md to setup the pre-commit?

I'm sorry for the mistakes. Now it's ok with my pre-commit's checking.

@daixinghome
Copy link
Contributor Author

Well, it seems that there is no testcase for ignore_too_much parameter in master version. I add the testing now.

@@ -63,8 +63,8 @@ def _match_by_tag(inp, params):
tags = tag_k[idx]
joints = np.concatenate((loc_k[idx], val_k[idx, :, None], tags), 1)
mask = joints[:, 2] > params.detection_threshold
tags = tags[mask]
joints = joints[mask]
tags = tags[mask] # shape: [M, L]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the code comment or make it a new line on the top.

Copy link
Collaborator

@jin-s13 jin-s13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me in general. And I have tested the accuracy, which is good also.
One minor comment is to unify the style of code commenting.

@jin-s13 jin-s13 requested a review from ly015 April 28, 2022 13:46
@ly015 ly015 merged commit 2dc9c31 into open-mmlab:master May 2, 2022
@daixinghome daixinghome deleted the fix-human-grouping branch May 5, 2022 02:26
@yaqi0510
Copy link

yaqi0510 commented Apr 3, 2023

daixinghome,您好!您在MMPose项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。
我们非常期待与您继续合作,OpenMMLab专门成立了贡献者组织MMSIG,为贡献者们提供开源证书、荣誉体系和专享好礼,可通过添加微信:openmmlabwx 联系我们(请备注mmsig+GitHub id),由衷希望您能加入!

Hi @daixinghome !First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There seems to be a bug in human grouping processing
5 participants