New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix bug of human skeleton grouping for params.ignore_too_much #1341
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
+ Coverage 84.12% 84.16% +0.04%
==========================================
Files 215 215
Lines 17689 17692 +3
Branches 3144 3145 +1
==========================================
+ Hits 14880 14891 +11
+ Misses 2018 2013 -5
+ Partials 791 788 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thank you for your contribution! @daixinghome |
I'm sorry for the mistakes. Now it's ok with my pre-commit's checking. |
Well, it seems that there is no testcase for ignore_too_much parameter in master version. I add the testing now. |
@@ -63,8 +63,8 @@ def _match_by_tag(inp, params): | |||
tags = tag_k[idx] | |||
joints = np.concatenate((loc_k[idx], val_k[idx, :, None], tags), 1) | |||
mask = joints[:, 2] > params.detection_threshold | |||
tags = tags[mask] | |||
joints = joints[mask] | |||
tags = tags[mask] # shape: [M, L] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the code comment or make it a new line on the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me in general. And I have tested the accuracy, which is good also.
One minor comment is to unify the style of code commenting.
daixinghome,您好!您在MMPose项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。 Hi @daixinghome !First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Motivation
Fix: #1336
Modification
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: