Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] xywh->xyxy calculation in sanity check #1367

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented May 10, 2022

Motivation

Fix #1333

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@jin-s13 jin-s13 requested a review from ly015 May 10, 2022 12:03
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1367 (879a095) into master (e7c7cad) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1367   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files         225      225           
  Lines       18979    18979           
  Branches     3386     3386           
=======================================
  Hits        15779    15779           
  Misses       2364     2364           
  Partials      836      836           
Flag Coverage Δ
unittests 83.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/datasets/datasets/animal/animal_ap10k_dataset.py 85.29% <100.00%> (ø)
...se/datasets/datasets/animal/animal_atrw_dataset.py 89.09% <100.00%> (ø)
...datasets/datasets/animal/animal_macaque_dataset.py 89.69% <100.00%> (ø)
...se/datasets/datasets/animal/animal_pose_dataset.py 89.69% <100.00%> (ø)
...datasets/datasets/top_down/topdown_coco_dataset.py 89.41% <100.00%> (ø)
...atasets/top_down/topdown_coco_wholebody_dataset.py 93.96% <100.00%> (ø)
...atasets/datasets/top_down/topdown_jhmdb_dataset.py 90.78% <100.00%> (ø)
...sets/top_down/topdown_posetrack18_video_dataset.py 85.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c7cad...879a095. Read the comment docs.

@ly015
Copy link
Member

ly015 commented May 10, 2022

Do we need to train a few models to verify the performance?

@liqikai9
Copy link
Collaborator

The test and train mAP with this change using this config: https://github.com/open-mmlab/mmpose/blob/master/configs/body/2d_kpt_sview_rgb_img/topdown_heatmap/coco/res50_coco_256x192.py,

is consistent with the previous results.

@ly015 ly015 merged commit 04e57f8 into master May 12, 2022
@ly015 ly015 mentioned this pull request May 20, 2022
6 tasks
@jin-s13 jin-s13 deleted the fix_x2_calculation branch June 16, 2022 02:01
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline detail
3 participants