Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update mmcv and markdown dependency version #1516

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

Update mmcv maximum version from 1.6.0 to 1.7.0

Modification

Update mmcv maximum version in

  • mmpose/__init__.py
  • FAQ

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis requested a review from ly015 July 27, 2022 04:43
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1516 (ff1d125) into master (fc0b7e6) will increase coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head ff1d125 differs from pull request most recent head 2c60830. Consider uploading reports for the commit 2c60830 to get more accurate results

@@           Coverage Diff           @@
##           master    #1516   +/-   ##
=======================================
  Coverage   84.45%   84.46%           
=======================================
  Files         236      236           
  Lines       20038    20039    +1     
  Branches     3603     3603           
=======================================
+ Hits        16924    16925    +1     
  Misses       2233     2233           
  Partials      881      881           
Flag Coverage Δ
unittests 84.36% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/inference_tracking.py 61.71% <75.00%> (+0.30%) ⬆️
mmpose/__init__.py 70.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04123e0...2c60830. Read the comment docs.

@ly015 ly015 changed the title [Fix] Update mmcv maximum version [Fix] Update mmcv and markdown dependency version Jul 27, 2022
@ly015 ly015 merged commit c1460e4 into open-mmlab:master Jul 27, 2022
@Ben-Louis Ben-Louis deleted the update-mmcv-version branch July 29, 2022 03:56
evendrow pushed a commit to evendrow/mmpose that referenced this pull request Dec 22, 2022
* update max mmcv version from 1.6.0 to 1.7.0

* try markdown version
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
* update max mmcv version from 1.6.0 to 1.7.0

* try markdown version
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* update max mmcv version from 1.6.0 to 1.7.0

* try markdown version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants