Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] refactor Associative Embedding codec #1603

Merged
merged 8 commits into from Sep 8, 2022

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Aug 28, 2022

Motivation

Add codecs for Associative Embedding.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

from .post_processing import gaussian_blur


def refine_keypoints(keypoints: np.ndarray,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a reminder, processing methods like these should be given in the documentation afterwards to facilitate user learning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions will be automatically included in the apis section of the documentation, with their signatures and docstrings showed on the page. Do you think we need extra documents for them?

@ly015 ly015 requested a review from Tau-J September 7, 2022 05:17
@ly015 ly015 merged commit 2a3a279 into open-mmlab:dev-1.x Sep 8, 2022
ly015 added a commit that referenced this pull request Sep 13, 2022
* add associative embedding codec

* refactor decoding [wip]

* refactor decoding process

* add associative embedding codec

* refactor decoding refinements

* add missing keypoint complement and unit test

* support dynamic input_size in decoding

* add unit test for decoding with dynamic size
ly015 added a commit that referenced this pull request Oct 14, 2022
* add associative embedding codec

* refactor decoding [wip]

* refactor decoding process

* add associative embedding codec

* refactor decoding refinements

* add missing keypoint complement and unit test

* support dynamic input_size in decoding

* add unit test for decoding with dynamic size
ly015 added a commit that referenced this pull request Oct 14, 2022
* add associative embedding codec

* refactor decoding [wip]

* refactor decoding process

* add associative embedding codec

* refactor decoding refinements

* add missing keypoint complement and unit test

* support dynamic input_size in decoding

* add unit test for decoding with dynamic size
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add associative embedding codec

* refactor decoding [wip]

* refactor decoding process

* add associative embedding codec

* refactor decoding refinements

* add missing keypoint complement and unit test

* support dynamic input_size in decoding

* add unit test for decoding with dynamic size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants