Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move file_client_args to default_runtime and rename test_pipeline to val_pipeline #1651

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

liqikai9
Copy link
Collaborator

@liqikai9 liqikai9 commented Sep 9, 2022

Motivation

Modification

  1. Move file_client_args to default_runtime.py.
  2. Rename test_pipeline to val_pipeline for val_dataloader

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015
Copy link
Member

ly015 commented Sep 14, 2022

Please rebase onto the latest dev-1.x branch and fix conflicts. Also please check it can pass all unit tests.

@liqikai9
Copy link
Collaborator Author

Please rebase onto the latest dev-1.x branch and fix conflicts. Also please check it can pass all unit tests.

Done.

@liqikai9 liqikai9 changed the title [Refactor] Modify some configs [Refactor] Move file_client_args to default_runtime and rename test_pipeline to val_pipeline Sep 15, 2022
@ly015 ly015 merged commit c53290a into open-mmlab:dev-1.x Sep 16, 2022
@liqikai9 liqikai9 deleted the modify-configs branch September 18, 2022 08:01
ly015 pushed a commit that referenced this pull request Oct 14, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants