Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp#158] SimCC 1d heatmap visualization #1912

Merged
merged 9 commits into from Feb 14, 2023

Conversation

jack0rich
Copy link
Contributor

@jack0rich jack0rich commented Jan 2, 2023

Motivation

Visualize SimCC one-dimensional heatmap.

Modification

A new method named _draw_instance_xy_heap is extended in PoseLocalVisualizer to support the visualization of heatmaps such as SimCC.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023

CLA assistant check
All committers have signed the CLA.

@jack0rich jack0rich closed this Jan 2, 2023
@jack0rich jack0rich reopened this Jan 2, 2023
@ly015 ly015 changed the title [add]SimCC 1d heatmap visualization [CodeCamp#158] SimCC 1d heatmap visualization Jan 3, 2023
@ly015
Copy link
Member

ly015 commented Jan 3, 2023

Thank you very much for your contribution. This PR will be reviewed asap.

@ly015 ly015 requested review from ly015 and Tau-J January 3, 2023 07:26
@@ -12,6 +12,7 @@

from mmpose.registry import VISUALIZERS
from mmpose.structures import PoseDataSample
from simCCVis import SimCCVisualizer
Copy link
Collaborator

@Tau-J Tau-J Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest renaming this file to simcc_vis.py and placing it under mmpose/visualization folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll revise it right away. Thank you for your suggestions.

@Tau-J
Copy link
Collaborator

Tau-J commented Jan 12, 2023

Hi @jack0rich , would you mind fixing the lint and adding an example of simcc visualization result to visualization docs?

@jack0rich
Copy link
Contributor Author

Hi @jack0rich , would you mind fixing the lint and adding an example of simcc visualization result to visualization docs?

Sure, but I'm confused about lint.Is there a problem with the copyright of simcc_vis.py?
93F2344E-E7F8-42FF-8352-E0BAFD69FBE5

@Ben-Louis
Copy link
Collaborator

Sure, but I'm confused about lint.Is there a problem with the copyright of simcc_vis.py? 93F2344E-E7F8-42FF-8352-E0BAFD69FBE5

Hi @jack0rich, the copyright description

# Copyright (c) OpenMMLab. All rights reserved.

is needed at the top of new files

@ly015 ly015 added the info/1.x Issue/PR related to branch 1.x label Jan 17, 2023
ly015 and others added 8 commits February 13, 2023 14:54
@ly015 ly015 force-pushed the jack0rich/SimCC_visualization branch from 704f5dc to b865dee Compare February 13, 2023 06:54
@ly015 ly015 changed the base branch from 1.x to dev-1.x February 14, 2023 03:16
@ly015 ly015 merged commit 82a0677 into open-mmlab:dev-1.x Feb 14, 2023
ly015 pushed a commit to ly015/mmpose that referenced this pull request Feb 21, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info/1.x Issue/PR related to branch 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants