Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CrowdPose dataset #195

Merged
merged 15 commits into from
Oct 18, 2020
Merged

Support CrowdPose dataset #195

merged 15 commits into from
Oct 18, 2020

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Oct 17, 2020

No description provided.

@jin-s13 jin-s13 requested a review from innerlee October 17, 2020 07:46
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #195 into master will increase coverage by 0.00%.
The diff coverage is 80.79%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #195    +/-   ##
========================================
  Coverage   83.10%   83.10%            
========================================
  Files         103      105     +2     
  Lines        6042     6144   +102     
  Branches      977      988    +11     
========================================
+ Hits         5021     5106    +85     
- Misses        831      849    +18     
+ Partials      190      189     -1     
Flag Coverage Δ
#unittests 83.10% <80.79%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...asets/datasets/bottom_up/bottom_up_base_dataset.py 82.50% <66.66%> (ø)
...pose/datasets/datasets/bottom_up/bottom_up_coco.py 48.32% <67.74%> (+5.25%) ⬆️
...datasets/datasets/bottom_up/bottom_up_crowdpose.py 75.67% <75.67%> (ø)
...ets/datasets/top_down/topdown_crowdpose_dataset.py 82.35% <82.35%> (ø)
mmpose/datasets/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/datasets/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/datasets/bottom_up/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/datasets/top_down/__init__.py 100.00% <100.00%> (ø)
.../datasets/datasets/top_down/topdown_aic_dataset.py 82.35% <100.00%> (ø)
...datasets/datasets/top_down/topdown_base_dataset.py 94.11% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe3d64d...3cdef45. Read the comment docs.

@@ -53,12 +53,12 @@ def __init__(self,
self.ann_info['inference_channel'] = data_cfg['inference_channel']
self.ann_info['dataset_channel'] = data_cfg['dataset_channel']

self.db = []
self.image_set_index = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to understand image set index? image set's index? image set index? what is an index?
why is this name better than db?

Copy link
Collaborator Author

@jin-s13 jin-s13 Oct 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is a list containing image ids. Maybe a better name is 'img_ids'.

@innerlee
Copy link
Contributor

looks good

@innerlee
Copy link
Contributor

need a follow up pr to update repo's readme and changelog

@innerlee innerlee merged commit 064c81a into master Oct 18, 2020
@innerlee innerlee mentioned this pull request Oct 18, 2020
7 tasks
@jin-s13 jin-s13 deleted the crowdpose_data branch October 22, 2020 03:48
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add crowdpose dataset

* add crowdpose

* add configs

* use trainval

* add bu crowdpose

* add bu crowdpose test

* add bu configs

* fix config

* fix config

* fix segmentation for crowdpose

* add pre-trained models

* update xtcocotools requirements

* update configs

* change the name to img_id and img_ids

* use idx
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* add crowdpose dataset

* add crowdpose

* add configs

* use trainval

* add bu crowdpose

* add bu crowdpose test

* add bu configs

* fix config

* fix config

* fix segmentation for crowdpose

* add pre-trained models

* update xtcocotools requirements

* update configs

* change the name to img_id and img_ids

* use idx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants