Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Doc about using CombinedDataset #2025

Merged
merged 5 commits into from Mar 10, 2023

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis requested a review from Tau-J March 7, 2023 08:14
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 81.59% and project coverage change: -0.05 ⚠️

Comparison is base (2016609) 82.21% compared to head (e2e353a) 82.16%.

❗ Current head e2e353a differs from pull request most recent head cf5e82f. Consider uploading reports for the commit cf5e82f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2025      +/-   ##
===========================================
- Coverage    82.21%   82.16%   -0.05%     
===========================================
  Files          220      224       +4     
  Lines        13100    13362     +262     
  Branches      2228     2265      +37     
===========================================
+ Hits         10770    10979     +209     
- Misses        1832     1870      +38     
- Partials       498      513      +15     
Flag Coverage Δ
unittests 82.16% <81.59%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/samplers.py 27.58% <0.00%> (-1.51%) ⬇️
mmpose/models/heads/heatmap_heads/__init__.py 100.00% <ø> (ø)
mmpose/models/losses/loss_wrappers.py 100.00% <ø> (ø)
mmpose/models/necks/gap_neck.py 59.09% <ø> (ø)
mmpose/models/utils/transformer.py 82.40% <ø> (ø)
mmpose/visualization/local_visualizer.py 79.00% <40.00%> (-0.66%) ⬇️
mmpose/engine/hooks/ema_hook.py 68.75% <68.75%> (ø)
mmpose/models/utils/rtmcc_block.py 72.65% <72.65%> (ø)
mmpose/models/heads/coord_cls_heads/rtmcc_head.py 96.66% <96.66%> (ø)
mmpose/datasets/dataset_wrappers.py 93.61% <100.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Ben-Louis and others added 3 commits March 7, 2023 16:44
Co-authored-by: Tau <674106399@qq.com>
@ly015 ly015 requested a review from Tau-J March 10, 2023 07:19
docs/en/advanced_guides/mixed_datasets.md Outdated Show resolved Hide resolved
docs/zh_cn/advanced_guides/mixed_datasets.md Outdated Show resolved Hide resolved
docs/zh_cn/advanced_guides/mixed_datasets.md Outdated Show resolved Hide resolved
docs/en/advanced_guides/mixed_datasets.md Outdated Show resolved Hide resolved
Co-authored-by: Tau <674106399@qq.com>
@ly015 ly015 merged commit a9fb680 into open-mmlab:dev-1.x Mar 10, 2023
6 of 7 checks passed
@Ben-Louis Ben-Louis deleted the doc-combined-dataset branch March 29, 2023 17:34
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants