Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor fileio #2087

Merged
merged 6 commits into from
Mar 21, 2023
Merged

[Refactor] Refactor fileio #2087

merged 6 commits into from
Mar 21, 2023

Conversation

Tau-J
Copy link
Collaborator

@Tau-J Tau-J commented Mar 17, 2023

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Tau-J Tau-J force-pushed the tau/fileio branch 2 times, most recently from a4e3b55 to 962aff6 Compare March 20, 2023 02:17
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (3af7fed) 81.46% compared to head (07dc00f) 81.56%.

❗ Current head 07dc00f differs from pull request most recent head 5dd39f6. Consider uploading reports for the commit 5dd39f6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2087      +/-   ##
===========================================
+ Coverage    81.46%   81.56%   +0.10%     
===========================================
  Files          227      227              
  Lines        13513    13509       -4     
  Branches      2306     2304       -2     
===========================================
+ Hits         11008    11019      +11     
+ Misses        1987     1972      -15     
  Partials       518      518              
Flag Coverage Δ
unittests 81.56% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/transforms/loading.py 100.00% <ø> (ø)
mmpose/engine/hooks/visualization_hook.py 89.65% <100.00%> (+2.55%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J requested a review from ly015 March 20, 2023 03:12
@ly015 ly015 merged commit 45486ea into open-mmlab:dev-1.x Mar 21, 2023
Tau-J added a commit that referenced this pull request Apr 6, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants