Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Inferencer support mmyolo detector #2122

Merged
merged 1 commit into from Mar 29, 2023

Conversation

Ben-Louis
Copy link
Collaborator

@Ben-Louis Ben-Louis commented Mar 25, 2023

Motivation

To allow the demo/inferencer_demo.py to utilize models from mmyolo for object detection in top-down pose estimation.

Modification

BC-breaking (Optional)

Use cases (Optional)

python demo/inferencer_demo.py tests/data/coco/000000000785.jpg --pose2d human \
    --det-model ${MMYOLO_PATH}/configs/yolox/yolox_tiny_fast_8xb8-300e_coco.py \
    --det-weights https://download.openmmlab.com/mmyolo/v0/yolox/yolox_tiny_8xb8-300e_coco/yolox_tiny_8xb8-300e_coco_20220919_090908-0e40a6fc.pth \
    --show

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.07 ⚠️

Comparison is base (71d74de) 82.44% compared to head (5e9796d) 82.38%.

❗ Current head 5e9796d differs from pull request most recent head 7d3107f. Consider uploading reports for the commit 7d3107f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2122      +/-   ##
===========================================
- Coverage    82.44%   82.38%   -0.07%     
===========================================
  Files          227      227              
  Lines        13324    13329       +5     
  Branches      2257     2258       +1     
===========================================
- Hits         10985    10981       -4     
- Misses        1829     1840      +11     
+ Partials       510      508       -2     
Flag Coverage Δ
unittests 82.38% <40.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/inferencers/pose2d_inferencer.py 72.80% <40.00%> (-1.51%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit a59183f into open-mmlab:dev-1.x Mar 29, 2023
6 of 7 checks passed
@Ben-Louis Ben-Louis deleted the inference-with-mmyolo branch March 29, 2023 17:33
Tau-J pushed a commit that referenced this pull request Apr 6, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants