Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsn backbone, head and pre-processing #221

Merged
merged 30 commits into from
Nov 12, 2020
Merged

Add rsn backbone, head and pre-processing #221

merged 30 commits into from
Nov 12, 2020

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Oct 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #221 (76ac0dd) into master (1436a45) will increase coverage by 0.77%.
The diff coverage is 78.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   82.82%   83.59%   +0.77%     
==========================================
  Files         106      113       +7     
  Lines        6217     6796     +579     
  Branches     1003     1083      +80     
==========================================
+ Hits         5149     5681     +532     
- Misses        878      918      +40     
- Partials      190      197       +7     
Flag Coverage Δ
unittests 83.59% <78.21%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/test.py 27.58% <0.00%> (-0.33%) ⬇️
mmpose/core/evaluation/eval_hooks.py 66.66% <0.00%> (ø)
mmpose/datasets/__init__.py 100.00% <ø> (ø)
...asets/datasets/bottom_up/bottom_up_base_dataset.py 82.50% <0.00%> (ø)
...pose/datasets/datasets/bottom_up/bottom_up_coco.py 48.32% <ø> (ø)
mmpose/datasets/datasets/mesh/mesh_h36m_dataset.py 22.41% <0.00%> (ø)
mmpose/datasets/datasets/mesh/mesh_mix_dataset.py 91.30% <0.00%> (-4.16%) ⬇️
...datasets/datasets/top_down/topdown_mpii_dataset.py 42.71% <ø> (ø)
...sets/datasets/top_down/topdown_mpii_trb_dataset.py 51.75% <ø> (ø)
mmpose/models/backbones/base_backbone.py 100.00% <ø> (+5.26%) ⬆️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1436a45...94427ba. Read the comment docs.

@wusize wusize requested a review from jin-s13 October 29, 2020 04:34
@jin-s13 jin-s13 requested a review from innerlee October 29, 2020 08:09
@jin-s13
Copy link
Collaborator

jin-s13 commented Oct 29, 2020

need unit-test for top_down_transform.py

@jin-s13 jin-s13 mentioned this pull request Oct 29, 2020
7 tasks
@jin-s13 jin-s13 mentioned this pull request Nov 4, 2020
9 tasks
@innerlee
Copy link
Contributor

innerlee commented Nov 6, 2020

tests are failing

@innerlee
Copy link
Contributor

tests are failing


if target_weight[i] < 1:
continue
target_y = joints_3d[i, 1] * H / image_size[1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make target_x and target_y int here

@innerlee
Copy link
Contributor

looks good after fixing the ci

@innerlee innerlee merged commit 04458ee into master Nov 12, 2020
@innerlee innerlee deleted the Add_RSN branch November 12, 2020 12:31
wusize added a commit that referenced this pull request Nov 13, 2020
* Add rsn

* Add unit test

* Modification

* Some corrections

* Corrections

* Correction in top_down_transform.py

* Correction in top_down_transform.py

* Add mspn

* unit test for mspn

* remove mspn

* rename mspn_head to msmu_head

* Add unit test for backbone and head

* fix a bug in rsn.py

* Add rsn

* Add unit test

* Modification

* Some corrections

* Corrections

* Correction in top_down_transform.py

* Correction in top_down_transform.py

* Add mspn

* unit test for mspn

* remove mspn

* rename mspn_head to msmu_head

* Add unit test for backbone and head

* fix a bug in rsn.py

* rm unnecessary codes

* add comment for 3-sigma rule

* fix some bugs

Co-authored-by: jinsheng <jinsheng@sensetime.com>
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* Add rsn

* Add unit test

* Modification

* Some corrections

* Corrections

* Correction in top_down_transform.py

* Correction in top_down_transform.py

* Add mspn

* unit test for mspn

* remove mspn

* rename mspn_head to msmu_head

* Add unit test for backbone and head

* fix a bug in rsn.py

* Add rsn

* Add unit test

* Modification

* Some corrections

* Corrections

* Correction in top_down_transform.py

* Correction in top_down_transform.py

* Add mspn

* unit test for mspn

* remove mspn

* rename mspn_head to msmu_head

* Add unit test for backbone and head

* fix a bug in rsn.py

* rm unnecessary codes

* add comment for 3-sigma rule

* fix some bugs

Co-authored-by: jinsheng <jinsheng@sensetime.com>
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
…-mmlab#221)

* [Feature] Support convert epoch-based schedulers to iter-based.

* Support convert and refactor LR and Momentum to mixin.

* Add unit tests

* fix args and add runner ut

* resolve comments
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* Add rsn

* Add unit test

* Modification

* Some corrections

* Corrections

* Correction in top_down_transform.py

* Correction in top_down_transform.py

* Add mspn

* unit test for mspn

* remove mspn

* rename mspn_head to msmu_head

* Add unit test for backbone and head

* fix a bug in rsn.py

* Add rsn

* Add unit test

* Modification

* Some corrections

* Corrections

* Correction in top_down_transform.py

* Correction in top_down_transform.py

* Add mspn

* unit test for mspn

* remove mspn

* rename mspn_head to msmu_head

* Add unit test for backbone and head

* fix a bug in rsn.py

* rm unnecessary codes

* add comment for 3-sigma rule

* fix some bugs

Co-authored-by: jinsheng <jinsheng@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants