Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Add codec for 3d body #2251

Merged
merged 9 commits into from
Apr 25, 2023
Merged

Conversation

LareinaM
Copy link
Collaborator

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@LareinaM LareinaM marked this pull request as draft April 18, 2023 07:32
@LareinaM LareinaM changed the title [WIP] [Refactor] Add 3d transforms and codec [WIP][Refactor] Add 3d transforms and codec Apr 18, 2023
@LareinaM LareinaM changed the title [WIP][Refactor] Add 3d transforms and codec [WIP][Refactor] Add codec for 3d body Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (refactor_3d@c64e032). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 955b1ee differs from pull request most recent head 86075d7. Consider uploading reports for the commit 86075d7 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             refactor_3d    #2251   +/-   ##
==============================================
  Coverage               ?   82.30%           
==============================================
  Files                  ?      236           
  Lines                  ?    14008           
  Branches               ?     2384           
==============================================
  Hits                   ?    11529           
  Misses                 ?     1915           
  Partials               ?      564           
Flag Coverage Δ
unittests 82.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LareinaM LareinaM marked this pull request as ready for review April 25, 2023 03:57
@LareinaM LareinaM changed the title [WIP][Refactor] Add codec for 3d body [Refactor] Add codec for 3d body Apr 25, 2023
Comment on lines 67 to 73
def flip_regression(keypoints: np.ndarray,
keypoints_visible: np.ndarray,
flip_indices: List[int],
center_mode: str = 'static',
center_x: float = 0.5,
center_index: int = 0):
"""Flip human joints horizontally.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest replacing flip_regression with flip_keypoints_custom_center, which can be more readable and differentiated from flip_keypoints()

@Tau-J Tau-J merged commit 7dc182c into open-mmlab:refactor_3d Apr 25, 2023
LareinaM added a commit to LareinaM/mmpose that referenced this pull request May 31, 2023
LareinaM added a commit to LareinaM/mmpose that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants