Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix and op bug in nms() #2286

Merged
merged 1 commit into from
Apr 23, 2023
Merged

[Fix] Fix and op bug in nms() #2286

merged 1 commit into from
Apr 23, 2023

Conversation

FishBigOcean
Copy link
Contributor

Motivation

fix and op bug

Modification

ind = list(vg > vis_thr) and list(vd > vis_thr)
change to
ind = list((vg > vis_thr) & (vd > vis_thr))
In python a non-empty array is considered true, so the previous statement becomes
ind = true and list(vd > vis_thr)

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2023

CLA assistant check
All committers have signed the CLA.

@Tau-J Tau-J changed the title fix and op bug [Fix] fix and/op bug in nms() Apr 23, 2023
@Tau-J Tau-J changed the title [Fix] fix and/op bug in nms() [Fix] Fix and op bug in nms() Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (896e9d5) 82.25% compared to head (5513b47) 82.31%.

❗ Current head 5513b47 differs from pull request most recent head 1680624. Consider uploading reports for the commit 1680624 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2286      +/-   ##
===========================================
+ Coverage    82.25%   82.31%   +0.06%     
===========================================
  Files          228      231       +3     
  Lines        13387    13576     +189     
  Branches      2268     2306      +38     
===========================================
+ Hits         11011    11175     +164     
- Misses        1862     1869       +7     
- Partials       514      532      +18     
Flag Coverage Δ
unittests 82.31% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit 8c2d3fa into open-mmlab:dev-1.x Apr 23, 2023
8 of 9 checks passed
Tau-J pushed a commit to Tau-J/mmpose that referenced this pull request Apr 25, 2023
Tau-J pushed a commit to Tau-J/mmpose that referenced this pull request Apr 25, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants